-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix miss index file while slice meta contains raw data only #26190
Conversation
Also the slice meta is really a bad and stupid design, there are even 3 cases for such simple logic:
Actually I guess the 4-th case exists, but it's hidden by the property: raw data is always larger than the index itself. Proposal: |
@yah01 E2e jenkins job failed, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov Report
@@ Coverage Diff @@
## master #26190 +/- ##
==========================================
- Coverage 82.18% 82.16% -0.02%
==========================================
Files 807 812 +5
Lines 109620 111077 +1457
==========================================
+ Hits 90089 91269 +1180
- Misses 16454 16685 +231
- Partials 3077 3123 +46
|
Signed-off-by: yah01 <yah2er0ne@outlook.com>
@yah01 E2e jenkins job failed, comment |
2 similar comments
@yah01 E2e jenkins job failed, comment |
@yah01 E2e jenkins job failed, comment |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, jiaoew1991, yah01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug
related #26178 #25780 #26131 #25905