Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miss index file while slice meta contains raw data only #26190

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Aug 8, 2023

/kind bug
related #26178 #25780 #26131 #25905

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Aug 8, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Aug 8, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 8, 2023
@yah01
Copy link
Member Author

yah01 commented Aug 8, 2023

Also the slice meta is really a bad and stupid design, there are even 3 cases for such simple logic:

  • no slice meta if index && raw data files are both small
  • slice meta contains raw data only if the index file is small
  • slice meta contains both files if they are both large

Actually I guess the 4-th case exists, but it's hidden by the property: raw data is always larger than the index itself.

Proposal:
The slice meta should be always generated, even there is only 1 small file.
Simple and easy to handle

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #26190 (624dbcb) into master (28cea5e) will decrease coverage by 0.02%.
Report is 15 commits behind head on master.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26190      +/-   ##
==========================================
- Coverage   82.18%   82.16%   -0.02%     
==========================================
  Files         807      812       +5     
  Lines      109620   111077    +1457     
==========================================
+ Hits        90089    91269    +1180     
- Misses      16454    16685     +231     
- Partials     3077     3123      +46     
Files Changed Coverage Δ
internal/core/src/index/VectorMemIndex.cpp 66.99% <78.57%> (-0.02%) ⬇️

... and 32 files with indirect coverage changes

Signed-off-by: yah01 <yah2er0ne@outlook.com>
@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

2 similar comments
@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jiaoew1991, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants