Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use last end position in pursuit mode #26144

Merged

Conversation

congqixia
Copy link
Contributor

See also #26097
/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Aug 4, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from czs007 and yhmo August 4, 2023 11:11
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 4, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 4, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 4, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor

/lgtm

@mergify
Copy link
Contributor

mergify bot commented Aug 4, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia force-pushed the fix_multiple_pos_discarded branch from 7005ef6 to ba5baff Compare August 5, 2023 05:38
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed lgtm size/XS Denotes a PR that changes 0-9 lines. labels Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #26144 (ba5baff) into master (f97d5a7) will increase coverage by 0.57%.
Report is 8 commits behind head on master.
The diff coverage is 87.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26144      +/-   ##
==========================================
+ Coverage   82.05%   82.62%   +0.57%     
==========================================
  Files         807      806       -1     
  Lines      109432   107232    -2200     
==========================================
- Hits        89789    88598    -1191     
+ Misses      16551    15556     -995     
+ Partials     3092     3078      -14     
Files Changed Coverage Δ
internal/querycoordv2/meta/collection_manager.go 87.21% <ø> (-0.19%) ⬇️
internal/querycoordv2/meta/target.go 90.32% <0.00%> (-9.68%) ⬇️
internal/rootcoord/util.go 84.00% <ø> (ø)
internal/storage/print_binlog.go 58.22% <53.84%> (-0.16%) ⬇️
internal/querycoordv2/job/job_load.go 89.70% <55.55%> (+0.69%) ⬆️
internal/querycoordv2/meta/target_manager.go 84.67% <73.33%> (-1.19%) ⬇️
internal/proxy/meta_cache.go 88.36% <81.69%> (+0.01%) ⬆️
internal/rootcoord/root_coord.go 89.93% <84.86%> (+7.35%) ⬆️
pkg/mq/msgstream/mq_msgstream.go 78.95% <98.93%> (+0.79%) ⬆️
internal/metastore/kv/rootcoord/kv_catalog.go 87.54% <100.00%> (+0.38%) ⬆️
... and 8 more

... and 183 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Aug 5, 2023
@sunby
Copy link
Contributor

sunby commented Aug 5, 2023

/lgtm

@sre-ci-robot sre-ci-robot merged commit 241117d into milvus-io:master Aug 5, 2023
@congqixia congqixia deleted the fix_multiple_pos_discarded branch August 7, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants