Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mmap for vector index #25877

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Enable mmap for vector index #25877

merged 1 commit into from
Aug 10, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Jul 24, 2023

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jul 24, 2023
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 24, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jul 24, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

4 similar comments
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01 yah01 force-pushed the mmap-vec-index branch 2 times, most recently from cfbed25 to 70aa3b9 Compare August 9, 2023 14:33
@yah01
Copy link
Member Author

yah01 commented Aug 9, 2023

As I have to test with a large enough dataset, but this leads to timeout, disable ASAN for this PR

@yah01 yah01 force-pushed the mmap-vec-index branch 2 times, most recently from 2389353 to e1e14b7 Compare August 9, 2023 17:50
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Enable mmap for vector index
16bee52 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

4 similar comments
@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

jiaoew1991
jiaoew1991 approved these changes Aug 10, 2023
View reviewed changes
internal/core/unittest/test_indexing.cpp
EXPECT_EQ(result->seg_offsets_[0], query_offset);
}
search_info.search_params_ = range_search_conf;
vec_index->Query(xq_dataset, search_info, nullptr);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some asserts?

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiaoew1991
Copy link
Contributor

/lgtm

@mergify mergify bot added the ci-passed label Aug 10, 2023
@yah01
Copy link
Member Author

yah01 commented Aug 10, 2023

/unhold

@sre-ci-robot sre-ci-robot merged commit 300fef4 into milvus-io:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaoew1991 jiaoew1991 jiaoew1991 approved these changes

@aoiasd aoiasd Awaiting requested review from aoiasd

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@jiaoew1991 jiaoew1991

Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yah01 @sre-ci-robot @jiaoew1991