Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-Pick] Make datanode load statslog lazy if SkipBFStatsLog is true #23877

Merged
merged 1 commit into from
May 6, 2023

Conversation

congqixia
Copy link
Contributor

Cherry-pick from branch 2.2.0
See also #22994
Related to #23477
/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 5, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels May 5, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 5, 2023
@mergify
Copy link
Contributor

mergify bot commented May 5, 2023

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #23877 (b135c41) into master (38f45c3) will increase coverage by 0.02%.
The diff coverage is 93.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23877      +/-   ##
==========================================
+ Coverage   79.80%   79.82%   +0.02%     
==========================================
  Files         744      744              
  Lines       97577    97650      +73     
==========================================
+ Hits        77867    77949      +82     
+ Misses      16551    16544       -7     
+ Partials     3159     3157       -2     
Impacted Files Coverage Δ
internal/datanode/channel_meta.go 94.27% <92.64%> (-0.11%) ⬇️
internal/datanode/data_sync_service.go 80.54% <100.00%> (+0.06%) ⬆️
internal/datanode/segment.go 81.48% <100.00%> (+3.22%) ⬆️

... and 14 files with indirect coverage changes

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@jiaoew1991
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 345855c into milvus-io:master May 6, 2023
@congqixia congqixia deleted the cp_23779 branch May 15, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants