Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for disable BF load #22997

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

xiaofan-luan
Copy link
Collaborator

see also #22994
Signed-off-by: xiaofan-luan xiaofan.luan@zilliz.com

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 26, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Mar 26, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 26, 2023

@xiaofan-luan ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Mar 26, 2023

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #22997 (70d602b) into 2.2.0 (cb11abe) will decrease coverage by 0.02%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #22997      +/-   ##
==========================================
- Coverage   80.96%   80.95%   -0.02%     
==========================================
  Files         717      717              
  Lines      100518   100531      +13     
==========================================
- Hits        81387    81382       -5     
- Misses      15969    15978       +9     
- Partials     3162     3171       +9     
Impacted Files Coverage Δ
internal/querynode/segment_loader.go 80.45% <0.00%> (-0.57%) ⬇️
internal/querynode/segment.go 80.22% <20.00%> (-0.43%) ⬇️
internal/util/paramtable/component_param.go 87.73% <100.00%> (+0.05%) ⬆️

... and 12 files with indirect coverage changes

@xiaofan-luan xiaofan-luan added ci-passed manual-pass manually set pass before ci-passed labeled labels Mar 28, 2023
@czs007
Copy link
Collaborator

czs007 commented Mar 28, 2023

/lgtm

@sre-ci-robot sre-ci-robot merged commit 6f1eb73 into milvus-io:2.2.0 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants