Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for disable BF load #22996

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

xiaofan-luan
Copy link
Collaborator

see also #22994
Signed-off-by: xiaofan-luan xiaofan.luan@zilliz.com

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 26, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Mar 26, 2023
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #22996 (72d2fe1) into master (5a914ae) will decrease coverage by 0.60%.
The diff coverage is 68.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22996      +/-   ##
==========================================
- Coverage   82.09%   81.49%   -0.60%     
==========================================
  Files         728      789      +61     
  Lines       98619   105371    +6752     
==========================================
+ Hits        80958    85876    +4918     
- Misses      14634    16197    +1563     
- Partials     3027     3298     +271     
Impacted Files Coverage Δ
internal/querynode/segment_loader.go 80.20% <0.00%> (-0.43%) ⬇️
internal/querynode/segment.go 81.04% <20.00%> (-0.45%) ⬇️
internal/proxy/task_index.go 73.58% <100.00%> (+1.33%) ⬆️
internal/util/paramtable/component_param.go 98.07% <100.00%> (+0.02%) ⬆️

... and 114 files with indirect coverage changes

@xiaofan-luan xiaofan-luan added ci-passed manual-pass manually set pass before ci-passed labeled labels Mar 28, 2023
@czs007
Copy link
Collaborator

czs007 commented Mar 28, 2023

/lgtm

@sre-ci-robot sre-ci-robot merged commit d051021 into milvus-io:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants