Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement json visitor for plan node #22897

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

longjiquan
Copy link
Contributor

/kind improvement

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Mar 21, 2023
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Mar 21, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #22897 (1e3882a) into sql_beta (348fba4) will increase coverage by 0.21%.
The diff coverage is 97.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##           sql_beta   #22897      +/-   ##
============================================
+ Coverage     81.64%   81.85%   +0.21%     
============================================
  Files           771      776       +5     
  Lines         99924   100230     +306     
============================================
+ Hits          81586    82048     +462     
+ Misses        15217    15068     -149     
+ Partials       3121     3114       -7     
Impacted Files Coverage Δ
internal/mysqld/parser/antlrparser/node_ret.go 43.68% <ø> (-3.27%) ⬇️
...mysqld/planner/visitor_expression_text_restorer.go 44.08% <ø> (ø)
internal/mysqld/planner/test_value.go 50.00% <50.00%> (ø)
...ld/parser/antlrparser/node_ret_wrong_var_naming.go 75.00% <75.00%> (ø)
internal/mysqld/parser/antlrparser/ast_builder.go 38.29% <100.00%> (ø)
internal/mysqld/planner/node_equal.go 100.00% <100.00%> (ø)
internal/mysqld/planner/sql_statements.go 100.00% <100.00%> (+13.33%) ⬆️
internal/mysqld/planner/visitor_json.go 100.00% <100.00%> (ø)
...al/mysqld/planner/visitor_json_wrong_var_naming.go 100.00% <100.00%> (ø)

... and 45 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 21, 2023
@czs007
Copy link
Collaborator

czs007 commented Mar 21, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ce2c5d1 into milvus-io:sql_beta Mar 21, 2023
@longjiquan longjiquan deleted the add-ut branch March 21, 2023 12:21
czs007 pushed a commit that referenced this pull request Apr 7, 2023
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
longjiquan added a commit to longjiquan/milvus that referenced this pull request Apr 12, 2023
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants