Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gernate milvus.yaml by code #22003

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

jiaoew1991
Copy link
Contributor

Signed-off-by: Enwei Jiao enwei.jiao@zilliz.com
/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Feb 6, 2023
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Feb 6, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Feb 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@jiaoew1991 jiaoew1991 force-pushed the forbid-danger-refresh branch from a299655 to 58991d3 Compare February 6, 2023 09:27
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jiaoew1991 jiaoew1991 force-pushed the forbid-danger-refresh branch from 58991d3 to ddc96e3 Compare February 6, 2023 09:56
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@jiaoew1991 jiaoew1991 force-pushed the forbid-danger-refresh branch from ddc96e3 to 6760877 Compare February 6, 2023 11:07
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@jiaoew1991 jiaoew1991 force-pushed the forbid-danger-refresh branch from 6760877 to 2338d79 Compare February 6, 2023 11:42
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@jiaoew1991 jiaoew1991 force-pushed the forbid-danger-refresh branch from 2338d79 to 3101546 Compare February 7, 2023 03:27
@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jiaoew1991 jiaoew1991 force-pushed the forbid-danger-refresh branch from 3101546 to 6af66f1 Compare February 7, 2023 05:38
@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@jiaoew1991 jiaoew1991 force-pushed the forbid-danger-refresh branch from 6af66f1 to ab403dc Compare February 7, 2023 06:27
@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@jiaoew1991 jiaoew1991 force-pushed the forbid-danger-refresh branch from ab403dc to b8b1ca5 Compare February 7, 2023 07:52
if val.Kind() != reflect.Struct {
return
}
log.Debug("enter", zap.Any("variable", val.String()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zap.String

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #22003 (e5fb665) into master (8ec5ba1) will increase coverage by 0.30%.
The diff coverage is 99.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22003      +/-   ##
==========================================
+ Coverage   82.16%   82.47%   +0.30%     
==========================================
  Files         703      703              
  Lines       97354    96159    -1195     
==========================================
- Hits        79989    79303     -686     
+ Misses      14392    13880     -512     
- Partials     2973     2976       +3     
Impacted Files Coverage Δ
internal/metastore/db/dbcore/core.go 8.45% <0.00%> (ø)
internal/util/paramtable/base_table.go 81.30% <ø> (-1.00%) ⬇️
internal/util/paramtable/param_item.go 91.86% <ø> (ø)
internal/util/typeutil/ordered_map.go 93.10% <93.10%> (ø)
internal/util/paramtable/component_param.go 98.36% <100.00%> (+0.32%) ⬆️
internal/util/paramtable/grpc_param.go 78.64% <100.00%> (+0.38%) ⬆️
internal/util/paramtable/http_param.go 100.00% <100.00%> (ø)
internal/util/paramtable/quota_param.go 73.58% <100.00%> (+1.28%) ⬆️
internal/util/paramtable/service_param.go 98.54% <100.00%> (+0.31%) ⬆️
internal/core/src/index/Index.h 50.00% <0.00%> (-50.00%) ⬇️
... and 162 more

@mergify mergify bot added the ci-passed label Feb 7, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jiaoew1991
Copy link
Contributor Author

/run-cpu-e2e

@jiaoew1991 jiaoew1991 force-pushed the forbid-danger-refresh branch from a533011 to 3c82b0c Compare February 14, 2023 11:29
@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jiaoew1991
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Feb 15, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jiaoew1991 jiaoew1991 force-pushed the forbid-danger-refresh branch from 3c82b0c to b9f951c Compare February 15, 2023 02:03
@haorenfsa
Copy link
Contributor

part of: #21856

@mergify
Copy link
Contributor

mergify bot commented Feb 15, 2023

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jiaoew1991
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Feb 15, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@jiaoew1991
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Feb 15, 2023
configs/milvus.yaml Outdated Show resolved Hide resolved
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
@jiaoew1991 jiaoew1991 force-pushed the forbid-danger-refresh branch from b9f951c to 5fa39cf Compare February 16, 2023 03:28
@mergify mergify bot removed the ci-passed label Feb 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2023

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

@congqixia
Copy link
Contributor

/lgtm

@jiaoew1991
Copy link
Contributor Author

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants