Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QueryCoord OWNERS file #21552

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Add QueryCoord OWNERS file #21552

merged 1 commit into from
Jan 10, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Jan 5, 2023

Signed-off-by: yah01 yang.cen@zilliz.com
/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jan 5, 2023
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 5, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jan 5, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: yah01 <yang.cen@zilliz.com>
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #21552 (4caa936) into master (23ceb9c) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21552      +/-   ##
==========================================
+ Coverage   82.07%   82.09%   +0.02%     
==========================================
  Files         691      691              
  Lines       94391    94391              
==========================================
+ Hits        77471    77495      +24     
+ Misses      14053    14035      -18     
+ Partials     2867     2861       -6     
Impacted Files Coverage Δ
internal/util/sessionutil/session_util.go 80.10% <0.00%> (-3.08%) ⬇️
internal/datacoord/segment_manager.go 86.27% <0.00%> (-2.25%) ⬇️
internal/querycoordv2/observers/target_observer.go 83.83% <0.00%> (-2.03%) ⬇️
internal/proxy/meta_cache.go 85.90% <0.00%> (-1.70%) ⬇️
internal/querynode/impl.go 66.69% <0.00%> (+0.15%) ⬆️
internal/datacoord/session_manager.go 83.75% <0.00%> (+0.50%) ⬆️
internal/indexnode/task.go 50.92% <0.00%> (+0.53%) ⬆️
internal/querycoordv2/task/scheduler.go 80.19% <0.00%> (+0.57%) ⬆️
internal/querycoordv2/task/executor.go 74.64% <0.00%> (+0.84%) ⬆️
internal/mq/msgstream/mq_msgstream.go 80.91% <0.00%> (+0.97%) ⬆️
... and 8 more

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3b41a69 into milvus-io:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants