Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase bulk insert file size limit #21526

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

soothing-rain
Copy link
Contributor

/kind improvement

Signed-off-by: Yuchen Gao yuchen.gao@zilliz.com

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jan 5, 2023
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 5, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jan 5, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2023

@soothing-rain ut workflow job failed, comment rerun ut can trigger the job again.

@soothing-rain
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2023

@soothing-rain ut workflow job failed, comment rerun ut can trigger the job again.

/kind improvement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #21526 (1f87e62) into master (58b79eb) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21526      +/-   ##
==========================================
- Coverage   81.86%   81.85%   -0.01%     
==========================================
  Files         711      711              
  Lines       98949    98955       +6     
==========================================
- Hits        81001    80997       -4     
- Misses      14944    14950       +6     
- Partials     3004     3008       +4     
Impacted Files Coverage Δ
internal/util/importutil/import_wrapper.go 85.51% <ø> (ø)
internal/kv/rocksdb/RocksIterator.go 72.09% <0.00%> (-6.98%) ⬇️
internal/util/cache/lru_impl.go 85.41% <0.00%> (-6.25%) ⬇️
internal/rootcoord/scheduler.go 96.29% <0.00%> (-3.71%) ⬇️
internal/util/importutil/json_parser.go 89.86% <0.00%> (-2.03%) ⬇️
internal/querycoordv2/observers/target_observer.go 83.83% <0.00%> (-2.03%) ⬇️
internal/querycoordv2/session/cluster.go 67.98% <0.00%> (-1.48%) ⬇️
internal/datacoord/segment_manager.go 88.00% <0.00%> (-0.86%) ⬇️
internal/proxy/meta_cache.go 85.90% <0.00%> (-0.76%) ⬇️
internal/datacoord/session_manager.go 83.24% <0.00%> (-0.51%) ⬇️
... and 16 more

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, soothing-rain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soothing-rain
Copy link
Contributor Author

rerun ut

@soothing-rain
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 6, 2023
@sre-ci-robot sre-ci-robot merged commit b3da554 into milvus-io:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants