Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bad & duplicate metric #20905

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

soothing-rain
Copy link
Contributor

/kind improvement

Signed-off-by: Yuchen Gao yuchen.gao@zilliz.com

/kind improvement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Nov 30, 2022
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 30, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #20905 (b5ac5de) into master (5a6a92d) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20905      +/-   ##
==========================================
- Coverage   81.69%   81.66%   -0.03%     
==========================================
  Files         692      692              
  Lines       93176    93179       +3     
==========================================
- Hits        76116    76094      -22     
- Misses      14000    14019      +19     
- Partials     3060     3066       +6     
Impacted Files Coverage Δ
internal/datanode/channel_meta.go 93.79% <ø> (-0.06%) ⬇️
internal/metrics/datanode_metrics.go 100.00% <ø> (ø)
internal/querycoordv2/job/scheduler.go 88.42% <0.00%> (-6.32%) ⬇️
internal/querycoordv2/dist/dist_handler.go 71.59% <0.00%> (-5.33%) ⬇️
internal/querycoordv2/checkers/segment_checker.go 85.41% <0.00%> (-1.57%) ⬇️
internal/querycoordv2/session/cluster.go 67.98% <0.00%> (-1.48%) ⬇️
internal/datacoord/segment_manager.go 86.24% <0.00%> (-1.44%) ⬇️
internal/indexcoord/flush_segment_watcher.go 95.88% <0.00%> (-1.24%) ⬇️
internal/distributed/querynode/client/client.go 89.81% <0.00%> (-1.14%) ⬇️
internal/indexcoord/garbage_collector.go 92.02% <0.00%> (-1.07%) ⬇️
... and 15 more

@mergify mergify bot added the ci-passed label Nov 30, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, soothing-rain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b238f4e into milvus-io:master Dec 1, 2022
@soothing-rain soothing-rain deleted the fixmetric1130 branch December 1, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants