Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compaction logs to make compaction plans trackable #20490

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

soothing-rain
Copy link
Contributor

/kind improvement

Signed-off-by: Yuchen Gao yuchen.gao@zilliz.com

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Nov 10, 2022
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 10, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Nov 10, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2022

@soothing-rain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2022

@soothing-rain ut workflow job failed, comment rerun ut can trigger the job again.

/kind improvement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #20490 (c1f24a2) into master (663bdf3) will decrease coverage by 0.02%.
The diff coverage is 39.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20490      +/-   ##
==========================================
- Coverage   81.30%   81.27%   -0.03%     
==========================================
  Files         765      765              
  Lines       93575    93610      +35     
==========================================
+ Hits        76077    76086       +9     
- Misses      14434    14457      +23     
- Partials     3064     3067       +3     
Impacted Files Coverage Δ
internal/datacoord/compaction.go 88.93% <0.00%> (-1.04%) ⬇️
internal/datacoord/compaction_trigger.go 83.39% <41.86%> (-2.65%) ⬇️
internal/indexnode/taskinfo_ops.go 82.08% <0.00%> (-8.96%) ⬇️
internal/kv/rocksdb/RocksIterator.go 72.09% <0.00%> (-6.98%) ⬇️
internal/querycoordv2/job/scheduler.go 88.54% <0.00%> (-6.25%) ⬇️
internal/querycoordv2/observers/target_observer.go 82.97% <0.00%> (-5.32%) ⬇️
internal/indexnode/task_scheduler.go 86.30% <0.00%> (-2.74%) ⬇️
internal/querycoordv2/checkers/segment_checker.go 84.81% <0.00%> (-2.10%) ⬇️
internal/querycoordv2/task/executor.go 73.04% <0.00%> (-1.45%) ⬇️
internal/datacoord/segment_manager.go 87.28% <0.00%> (-1.45%) ⬇️
... and 14 more

@czs007
Copy link
Collaborator

czs007 commented Nov 15, 2022

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, soothing-rain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 480a2b8 into milvus-io:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants