Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine NQ check logic #19819

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Refine NQ check logic #19819

merged 1 commit into from
Oct 18, 2022

Conversation

soothing-rain
Copy link
Contributor

issue: #19682

/kind improvement

Signed-off-by: Yuchen Gao yuchen.gao@zilliz.com

@soothing-rain
Refine NQ check logic
c30511d 
issue: milvus-io#19682

/kind improvement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 17, 2022
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 17, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #19819 (c30511d) into master (1587878) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19819   +/-   ##
=======================================
  Coverage   73.27%   73.27%           
=======================================
  Files         147      147           
  Lines        6145     6145           
=======================================
  Hits         4503     4503           
  Misses       1642     1642

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2022

@soothing-rain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

2 similar comments
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2022

@soothing-rain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2022

@soothing-rain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia
congqixia approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, soothing-rain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Oct 18, 2022
@sre-ci-robot sre-ci-robot merged commit a4a6f60 into milvus-io:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soothing-rain @sre-ci-robot @congqixia @yanliang567