Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ttFactor in QuoterCenter #19802

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

bigsheeper
Copy link
Contributor

Signed-off-by: bigsheeper yihao.dai@zilliz.com

issues: #19750

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot requested review from cydrain and yhmo October 15, 2022 16:03
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 15, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Oct 15, 2022
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #19802 (38cb912) into master (89c9cb3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19802      +/-   ##
==========================================
- Coverage   81.18%   81.16%   -0.02%     
==========================================
  Files         664      664              
  Lines       90501    90501              
==========================================
- Hits        73471    73459      -12     
- Misses      13987    13997      +10     
- Partials     3043     3045       +2     
Impacted Files Coverage Δ
internal/rootcoord/quota_center.go 75.25% <0.00%> (ø)
internal/indexnode/taskinfo_ops.go 82.08% <0.00%> (-8.96%) ⬇️
internal/indexnode/task_scheduler.go 86.30% <0.00%> (-2.74%) ⬇️
internal/datanode/flow_graph_dd_node.go 88.97% <0.00%> (-2.45%) ⬇️
internal/querycoordv2/task/executor.go 73.25% <0.00%> (-2.44%) ⬇️
internal/datacoord/segment_manager.go 86.70% <0.00%> (-2.03%) ⬇️
internal/indexcoord/garbage_collector.go 91.84% <0.00%> (-1.09%) ⬇️
internal/indexcoord/index_builder.go 98.96% <0.00%> (-0.78%) ⬇️
internal/datacoord/meta.go 87.15% <0.00%> (-0.64%) ⬇️
internal/indexnode/task.go 50.40% <0.00%> (-0.55%) ⬇️
... and 9 more

@czs007
Copy link
Collaborator

czs007 commented Oct 16, 2022

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a92b242 into milvus-io:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants