Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable search with pagination #19044

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

XuanYang-cn
Copy link
Contributor

See also: #19043

Signed-off-by: yangxuan xuan.yang@zilliz.com

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Sep 6, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Sep 6, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #19044 (e9e0bef) into master (362c663) will increase coverage by 0.05%.
The diff coverage is 82.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19044      +/-   ##
==========================================
+ Coverage   81.25%   81.31%   +0.05%     
==========================================
  Files         572      572              
  Lines       82050    82108      +58     
==========================================
+ Hits        66672    66764      +92     
+ Misses      12546    12513      -33     
+ Partials     2832     2831       -1     
Impacted Files Coverage Δ
internal/proxy/task_search.go 78.74% <81.45%> (+0.45%) ⬆️
internal/proxy/util.go 87.52% <100.00%> (ø)
internal/proxy/channels_time_ticker.go 80.59% <0.00%> (-2.24%) ⬇️
internal/datacoord/handler.go 92.59% <0.00%> (-1.86%) ⬇️
internal/querycoord/querynode.go 70.44% <0.00%> (-1.48%) ⬇️
internal/metastore/kv/datacoord/kv_catalog.go 78.21% <0.00%> (-1.17%) ⬇️
internal/datacoord/channel_manager.go 70.03% <0.00%> (-1.07%) ⬇️
internal/datanode/flow_graph_insert_buffer_node.go 91.79% <0.00%> (-0.65%) ⬇️
internal/querycoord/task.go 77.72% <0.00%> (+0.26%) ⬆️
... and 12 more

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Sep 6, 2022
@mergify mergify bot added the ci-passed label Sep 6, 2022
@XuanYang-cn
Copy link
Contributor Author

/assign @xiaofan-luan @jiaoew1991

internal/proxy/task_search.go Show resolved Hide resolved
internal/proxy/task_search.go Show resolved Hide resolved
internal/proxy/task_search.go Show resolved Hide resolved
internal/proxy/task_search.go Show resolved Hide resolved
See also: milvus-io#19043

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
)

// skip offset results
for k := int64(0); k < offset; k++ {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use one loop should work?

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 200df76 into milvus-io:master Sep 14, 2022
@XuanYang-cn XuanYang-cn deleted the search-pagination branch September 15, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants