-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable search with pagination #19044
Conversation
@XuanYang-cn ut workflow job failed, comment |
Codecov Report
@@ Coverage Diff @@
## master #19044 +/- ##
==========================================
+ Coverage 81.25% 81.31% +0.05%
==========================================
Files 572 572
Lines 82050 82108 +58
==========================================
+ Hits 66672 66764 +92
+ Misses 12546 12513 -33
+ Partials 2832 2831 -1
|
230f6e3
to
7b4b599
Compare
/assign @xiaofan-luan @jiaoew1991 |
See also: milvus-io#19043 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
7b4b599
to
e9e0bef
Compare
) | ||
|
||
// skip offset results | ||
for k := int64(0); k < offset; k++ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use one loop should work?
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See also: #19043
Signed-off-by: yangxuan xuan.yang@zilliz.com