Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit to proto #18950

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Add limit to proto #18950

merged 1 commit into from
Sep 1, 2022

Conversation

XuanYang-cn
Copy link
Contributor

See also: #18893

Signed-off-by: yangxuan xuan.yang@zilliz.com

@mergify mergify bot added the dco-passed DCO check passed. label Aug 31, 2022
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #18950 (da1868f) into master (0e4e796) will decrease coverage by 0.00%.
The diff coverage is 91.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18950      +/-   ##
==========================================
- Coverage   81.19%   81.18%   -0.01%     
==========================================
  Files         540      540              
  Lines       81581    81616      +35     
==========================================
+ Hits        66242    66263      +21     
- Misses      12487    12497      +10     
- Partials     2852     2856       +4     
Impacted Files Coverage Δ
internal/proxy/task.go 84.40% <ø> (ø)
internal/proxy/task_query.go 71.18% <91.42%> (+2.27%) ⬆️
internal/util/grpcclient/client.go 92.50% <0.00%> (-1.88%) ⬇️
internal/querycoord/querynode.go 70.44% <0.00%> (-1.48%) ⬇️
internal/mq/mqimpl/rocksmq/client/client_impl.go 79.66% <0.00%> (-0.85%) ⬇️
internal/proxy/util.go 87.52% <0.00%> (-0.59%) ⬇️
internal/querycoord/task.go 77.45% <0.00%> (-0.59%) ⬇️
internal/mq/msgstream/mq_msgstream.go 79.17% <0.00%> (-0.15%) ⬇️
internal/datacoord/server.go 76.79% <0.00%> (+0.65%) ⬆️
internal/proxy/segment.go 89.39% <0.00%> (+1.51%) ⬆️
... and 1 more

@mergify mergify bot added the ci-passed label Aug 31, 2022
@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia

See also: milvus-io#18893

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Sep 1, 2022
@mergify mergify bot removed the ci-passed label Sep 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added ci-passed and removed ci-passed labels Sep 1, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c054873 into milvus-io:master Sep 1, 2022
@XuanYang-cn XuanYang-cn deleted the page-4 branch April 26, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants