Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add merger for retrieve results #18948

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Add merger for retrieve results #18948

merged 1 commit into from
Sep 15, 2022

Conversation

XuanYang-cn
Copy link
Contributor

See also: #18893

Signed-off-by: yangxuan xuan.yang@zilliz.com

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Aug 31, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022 •
edited
Loading

Codecov Report

Merging #18948 (bf6be4f) into master (92857a4) will increase coverage by 0.00%.
The diff coverage is 93.22%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #18948    +/-   ##
========================================
  Coverage   81.60%   81.60%            
========================================
  Files         591      591            
  Lines       82862    82980   +118     
========================================
+ Hits        67620    67717    +97     
- Misses      12385    12404    +19     
- Partials     2857     2859     +2
Impacted Files Coverage Δ
internal/querynode/result.go 71.10% <93.22%> (+3.87%) ⬆️
internal/proxy/channels_time_ticker.go 80.59% <0.00%> (-2.24%) ⬇️
internal/datacoord/segment_manager.go 83.10% <0.00%> (-2.22%) ⬇️
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-1.70%) ⬇️
internal/proxy/segment.go 87.87% <0.00%> (-1.52%) ⬇️
internal/mq/msgstream/mq_msgstream.go 78.61% <0.00%> (-0.85%) ⬇️
internal/querynode/query_node.go 81.52% <0.00%> (-0.81%) ⬇️
internal/log/zap_text_encoder.go 83.17% <0.00%> (-0.71%) ⬇️
internal/querycoord/task.go 78.04% <0.00%> (+0.21%) ⬆️
... and 7 more

@mergify mergify bot added the ci-passed label Aug 31, 2022
@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia

@mergify mergify bot added ci-passed and removed ci-passed labels Sep 1, 2022
jiaoew1991
jiaoew1991 reviewed Sep 2, 2022
View reviewed changes
internal/querynode/result.go Show resolved Hide resolved
internal/querynode/result.go Outdated Show resolved Hide resolved
@XuanYang-cn
Copy link
Contributor Author

/assign @jiaoew1991 @xiaofan-luan

@mergify mergify bot removed the ci-passed label Sep 13, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Sep 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Add merger for retrieve results
bf6be4f 
See also: milvus-io#18893

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify mergify bot added the ci-passed label Sep 15, 2022
@jiaoew1991
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit ac1982c into milvus-io:master Sep 15, 2022
@XuanYang-cn XuanYang-cn deleted the page-3-1 branch April 26, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaoew1991 jiaoew1991 jiaoew1991 left review comments

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xige-16 xige-16 Awaiting requested review from xige-16

Assignees

@jiaoew1991 jiaoew1991

@xiaofan-luan xiaofan-luan

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XuanYang-cn @xiaofan-luan @sre-ci-robot @jiaoew1991 @congqixia