-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable sort for segcore RetrieveResults #18894
Conversation
@XuanYang-cn E2e jenkins job failed, comment |
@XuanYang-cn ut workflow job failed, comment |
@XuanYang-cn ut workflow job failed, comment |
@XuanYang-cn ut workflow job failed, comment |
@XuanYang-cn ut workflow job failed, comment |
@XuanYang-cn ut workflow job failed, comment |
@XuanYang-cn E2e jenkins job failed, comment |
Codecov Report
@@ Coverage Diff @@
## master #18894 +/- ##
==========================================
+ Coverage 81.52% 81.55% +0.02%
==========================================
Files 539 540 +1
Lines 81169 81249 +80
==========================================
+ Hits 66176 66262 +86
+ Misses 12143 12140 -3
+ Partials 2850 2847 -3
|
@XuanYang-cn E2e jenkins job failed, comment |
See also: milvus-io#18893 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn ut workflow job failed, comment |
rerun ut |
@XuanYang-cn ut workflow job failed, comment |
rerun ut |
@XuanYang-cn ut workflow job failed, comment |
rerun ut |
/assign @congqixia |
/assign @xiaofan-luan @jiaoew1991 |
add a sort step in query path maybe affect query latency. otherwise LGTM |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See also: #18893
Signed-off-by: yangxuan xuan.yang@zilliz.com