Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sort for segcore RetrieveResults #18894

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

XuanYang-cn
Copy link
Contributor

See also: #18893

Signed-off-by: yangxuan xuan.yang@zilliz.com

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Aug 29, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Aug 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Aug 30, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #18894 (6f40c05) into master (2ef8b15) will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18894      +/-   ##
==========================================
+ Coverage   81.52%   81.55%   +0.02%     
==========================================
  Files         539      540       +1     
  Lines       81169    81249      +80     
==========================================
+ Hits        66176    66262      +86     
+ Misses      12143    12140       -3     
+ Partials     2850     2847       -3     
Impacted Files Coverage Δ
internal/querynode/task_query.go 43.80% <0.00%> (-0.37%) ⬇️
internal/querynode/result.go 67.23% <66.66%> (-0.87%) ⬇️
internal/querynode/result_sorter.go 85.71% <85.71%> (ø)
internal/util/typeutil/schema.go 69.57% <92.30%> (+0.58%) ⬆️
internal/indexcoord/flush_segment_watcher.go 63.47% <100.00%> (+0.10%) ⬆️
internal/querynode/segment.go 82.75% <100.00%> (+0.02%) ⬆️
internal/querynode/shard_cluster.go 98.19% <100.00%> (-0.01%) ⬇️
internal/datacoord/segment_manager.go 82.82% <0.00%> (-1.39%) ⬇️
internal/util/flowgraph/node.go 73.60% <0.00%> (-0.81%) ⬇️
internal/mq/msgstream/mq_msgstream.go 78.47% <0.00%> (-0.71%) ⬇️
... and 9 more

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Aug 30, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

See also: milvus-io#18893

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Aug 31, 2022
@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia

@XuanYang-cn
Copy link
Contributor Author

/assign @xiaofan-luan @jiaoew1991

@jiaoew1991
Copy link
Contributor

add a sort step in query path maybe affect query latency. otherwise LGTM

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 086eb92 into milvus-io:master Sep 14, 2022
@XuanYang-cn XuanYang-cn deleted the page-2 branch September 14, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants