Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TopK check inside parseQueryInfo #18892

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

XuanYang-cn
Copy link
Contributor

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind improvement

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Aug 29, 2022
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Aug 29, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #18892 (0b05679) into master (9dc3bbe) will decrease coverage by 0.01%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18892      +/-   ##
==========================================
- Coverage   81.42%   81.41%   -0.02%     
==========================================
  Files         539      539              
  Lines       81183    81186       +3     
==========================================
- Hits        66107    66101       -6     
- Misses      12223    12230       +7     
- Partials     2853     2855       +2     
Impacted Files Coverage Δ
internal/proxy/task.go 84.40% <ø> (ø)
internal/querynode/segment_loader.go 76.56% <0.00%> (-0.31%) ⬇️
internal/util/dependency/factory.go 33.33% <0.00%> (ø)
internal/proxy/task_search.go 78.29% <100.00%> (+0.58%) ⬆️
internal/querycoord/cluster.go 81.51% <100.00%> (+0.19%) ⬆️
internal/querycoord/task.go 77.67% <100.00%> (+0.02%) ⬆️
internal/querycoord/group_balance.go 67.30% <0.00%> (-3.85%) ⬇️
internal/util/grpcclient/client.go 92.50% <0.00%> (-1.88%) ⬇️
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-1.70%) ⬇️
internal/datacoord/segment_manager.go 82.82% <0.00%> (-1.39%) ⬇️
... and 10 more

@mergify mergify bot added the ci-passed label Aug 29, 2022
@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 867ea63 into milvus-io:master Aug 30, 2022
@XuanYang-cn XuanYang-cn deleted the page-1 branch April 26, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants