-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TopK check inside parseQueryInfo #18892
Conversation
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Codecov Report
@@ Coverage Diff @@
## master #18892 +/- ##
==========================================
- Coverage 81.42% 81.41% -0.02%
==========================================
Files 539 539
Lines 81183 81186 +3
==========================================
- Hits 66107 66101 -6
- Misses 12223 12230 +7
- Partials 2853 2855 +2
|
/assign @congqixia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yangxuan xuan.yang@zilliz.com
/kind improvement