Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zstd lib in docker images #18823

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

XuanYang-cn
Copy link
Contributor

See also: #18304, #18335

Signed-off-by: yangxuan xuan.yang@zilliz.com

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Aug 25, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Aug 25, 2022
@XuanYang-cn
Copy link
Contributor Author

/assign @jennyli-z

See also: milvus-io#18304, milvus-io#18335

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@jennyli-z
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #18823 (0b2423d) into master (d443b54) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18823      +/-   ##
==========================================
- Coverage   82.68%   82.64%   -0.05%     
==========================================
  Files         533      533              
  Lines       81701    81701              
==========================================
- Hits        67554    67521      -33     
- Misses      11250    11275      +25     
- Partials     2897     2905       +8     
Impacted Files Coverage Δ
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-2.55%) ⬇️
internal/datacoord/segment_manager.go 81.99% <0.00%> (-1.94%) ⬇️
internal/util/grpcclient/client.go 92.50% <0.00%> (-1.88%) ⬇️
internal/datacoord/meta.go 91.73% <0.00%> (-0.73%) ⬇️
internal/querycoord/task.go 77.00% <0.00%> (-0.70%) ⬇️
internal/querycoord/query_coord.go 78.31% <0.00%> (-0.57%) ⬇️
internal/datacoord/services.go 85.06% <0.00%> (-0.31%) ⬇️
internal/mq/msgstream/mq_msgstream.go 79.03% <0.00%> (-0.29%) ⬇️
internal/mq/mqimpl/rocksmq/server/rocksmq_impl.go 81.37% <0.00%> (+0.42%) ⬆️
internal/querycoord/querynode.go 71.92% <0.00%> (+1.47%) ⬆️

@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 769606c into milvus-io:master Aug 25, 2022
@XuanYang-cn XuanYang-cn deleted the ir-docker branch August 25, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants