Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in error message #18688

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Conversation

XuanYang-cn
Copy link
Contributor

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Aug 17, 2022
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 17, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Aug 17, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #18688 (4474338) into master (d4c54d9) will increase coverage by 0.04%.
The diff coverage is 91.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18688      +/-   ##
==========================================
+ Coverage   82.45%   82.49%   +0.04%     
==========================================
  Files         520      520              
  Lines       80435    80444       +9     
==========================================
+ Hits        66319    66366      +47     
+ Misses      11239    11209      -30     
+ Partials     2877     2869       -8     
Impacted Files Coverage Δ
internal/core/src/segcore/Utils.cpp 74.28% <ø> (ø)
internal/datanode/segment_replica.go 92.55% <ø> (ø)
internal/datanode/flow_graph_delete_node.go 94.17% <90.62%> (+10.92%) ⬆️
internal/proxy/task_search.go 78.49% <100.00%> (+2.83%) ⬆️
internal/querycoord/segment_allocator.go 80.62% <0.00%> (-4.38%) ⬇️
internal/proxy/channels_time_ticker.go 80.59% <0.00%> (-2.24%) ⬇️
internal/util/grpcclient/client.go 92.50% <0.00%> (-1.88%) ⬇️
internal/proxy/segment.go 87.87% <0.00%> (-1.52%) ⬇️
internal/datacoord/meta.go 87.53% <0.00%> (-0.65%) ⬇️
internal/datacoord/services.go 85.74% <0.00%> (-0.31%) ⬇️
... and 12 more

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Aug 18, 2022
@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e05e9cb into milvus-io:master Aug 19, 2022
@XuanYang-cn XuanYang-cn deleted the fix-error-msg branch August 19, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants