Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flush panic after compaction #18677

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

XuanYang-cn
Copy link
Contributor

See also: #18565

Signed-off-by: yangxuan xuan.yang@zilliz.com

@sre-ci-robot sre-ci-robot requested review from cydrain and sunby August 16, 2022 07:53
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 16, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Aug 16, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

See also: milvus-io#18565

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn force-pushed the fix-compaction-panic branch from e0811d7 to a294ea6 Compare August 16, 2022 11:26
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #18677 (a294ea6) into master (be933a7) will increase coverage by 0.04%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18677      +/-   ##
==========================================
+ Coverage   82.42%   82.47%   +0.04%     
==========================================
  Files         520      520              
  Lines       80430    80444      +14     
==========================================
+ Hits        66293    66343      +50     
+ Misses      11256    11223      -33     
+ Partials     2881     2878       -3     
Impacted Files Coverage Δ
internal/datanode/segment_replica.go 92.55% <ø> (ø)
internal/datanode/flow_graph_delete_node.go 94.17% <90.62%> (+10.92%) ⬆️
internal/querycoord/segment_allocator.go 83.75% <0.00%> (-1.25%) ⬇️
internal/indexcoord/meta_table.go 93.72% <0.00%> (-1.13%) ⬇️
internal/log/zap_text_encoder.go 83.17% <0.00%> (-0.71%) ⬇️
internal/datacoord/meta.go 87.53% <0.00%> (-0.65%) ⬇️
internal/indexcoord/index_coord.go 81.56% <0.00%> (-0.42%) ⬇️
internal/datacoord/services.go 85.74% <0.00%> (-0.31%) ⬇️
internal/rootcoord/root_coord.go 76.46% <0.00%> (+0.07%) ⬆️
internal/datacoord/segment_manager.go 84.21% <0.00%> (+0.27%) ⬆️
... and 8 more

@mergify mergify bot added the ci-passed label Aug 17, 2022
@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 16dcd97 into milvus-io:master Aug 17, 2022
@XuanYang-cn XuanYang-cn deleted the fix-compaction-panic branch April 26, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants