Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DN flowgraph delete buffer logs #18657

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

XuanYang-cn
Copy link
Contributor

  1. Remove logs about not existing segments.
  2. Group logs by timestamp.
  3. Log changed segments only.
  4. Pair the segments reference lock and unlock log by taskID.

Resolves: #18655

Signed-off-by: yangxuan xuan.yang@zilliz.com

1. Remove logs about not existing segments.
2. Group logs by timestamp.
3. Log changed segments only.
4. Pair the segments reference lock and unlock log by taskID.

Resolves: milvus-io#18655

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Aug 15, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #18657 (ced41d2) into master (8a70f2b) will increase coverage by 0.00%.
The diff coverage is 92.85%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18657   +/-   ##
=======================================
  Coverage   82.41%   82.42%           
=======================================
  Files         520      520           
  Lines       80449    80449           
=======================================
+ Hits        66306    66307    +1     
+ Misses      11260    11258    -2     
- Partials     2883     2884    +1     
Impacted Files Coverage Δ
internal/datanode/flow_graph_delete_node.go 83.24% <92.30%> (+2.53%) ⬆️
internal/datacoord/segment_reference_manager.go 95.23% <100.00%> (ø)
internal/distributed/querycoord/client/client.go 71.09% <0.00%> (-1.90%) ⬇️
internal/config/manager.go 83.59% <0.00%> (-1.59%) ⬇️
internal/querycoord/task_scheduler.go 78.35% <0.00%> (-0.82%) ⬇️
internal/rootcoord/meta_table.go 89.01% <0.00%> (-0.51%) ⬇️
internal/mq/msgstream/mq_msgstream.go 78.75% <0.00%> (-0.43%) ⬇️
internal/rootcoord/task.go 78.63% <0.00%> (-0.38%) ⬇️
internal/datacoord/segment_manager.go 83.65% <0.00%> (+0.27%) ⬆️
internal/querycoord/task.go 77.27% <0.00%> (+0.31%) ⬆️
... and 5 more

@mergify mergify bot added the ci-passed label Aug 15, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4c86cc6 into milvus-io:master Aug 15, 2022
@XuanYang-cn XuanYang-cn deleted the fix-18655 branch August 17, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Delete buffer status in DN is lack of information
3 participants