Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message type of show partitions #17821

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

XuanYang-cn
Copy link
Contributor

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind improvement

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jun 27, 2022
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 27, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jun 27, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-checks can trigger the job again.

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #17821 (6371ee1) into master (9d2e5aa) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17821      +/-   ##
==========================================
- Coverage   81.13%   81.09%   -0.04%     
==========================================
  Files         472      472              
  Lines       74917    74917              
==========================================
- Hits        60783    60755      -28     
- Misses      11459    11479      +20     
- Partials     2675     2683       +8     
Impacted Files Coverage Δ
internal/proxy/task_search.go 62.54% <100.00%> (ø)
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-4.24%) ⬇️
internal/proxy/channels_time_ticker.go 80.59% <0.00%> (-2.24%) ⬇️
internal/rootcoord/task.go 77.43% <0.00%> (-1.17%) ⬇️
internal/datacoord/segment_manager.go 84.98% <0.00%> (-0.91%) ⬇️
internal/mq/msgstream/mq_msgstream.go 78.64% <0.00%> (-0.87%) ⬇️
internal/querycoord/task.go 76.69% <0.00%> (-0.66%) ⬇️
internal/querycoord/index_checker.go 74.25% <0.00%> (-0.60%) ⬇️
internal/rootcoord/meta_table.go 80.60% <0.00%> (-0.33%) ⬇️
internal/proxy/util.go 86.42% <0.00%> (+0.71%) ⬆️
... and 2 more

@mergify mergify bot added the ci-passed label Jun 27, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6b72f90 into milvus-io:master Jun 28, 2022
@XuanYang-cn XuanYang-cn deleted the fix-msgtype branch June 28, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants