Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance channel manager ut #17682

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

XuanYang-cn
Copy link
Contributor

Resolves: #17676

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jun 21, 2022
@sre-ci-robot sre-ci-robot requested review from congqixia and sunby June 21, 2022 10:54
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 21, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jun 21, 2022
Resolves: milvus-io#17676

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #17682 (5411936) into master (746aeea) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17682      +/-   ##
==========================================
- Coverage   81.01%   80.98%   -0.03%     
==========================================
  Files         468      468              
  Lines       74414    74414              
==========================================
- Hits        60286    60264      -22     
- Misses      11446    11466      +20     
- Partials     2682     2684       +2     
Impacted Files Coverage Δ
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-1.70%) ⬇️
internal/querycoord/querynode.go 72.03% <0.00%> (-1.28%) ⬇️
internal/distributed/datacoord/client/client.go 69.41% <0.00%> (-1.23%) ⬇️
internal/querycoord/index_checker.go 74.25% <0.00%> (-0.60%) ⬇️
internal/querycoord/cluster.go 79.61% <0.00%> (-0.59%) ⬇️
internal/proxy/impl.go 89.56% <0.00%> (-0.50%) ⬇️
internal/querycoord/task.go 77.28% <0.00%> (-0.43%) ⬇️
internal/indexcoord/meta_table.go 82.93% <0.00%> (-0.25%) ⬇️
internal/querycoord/task_scheduler.go 78.68% <0.00%> (-0.24%) ⬇️
internal/rootcoord/meta_table.go 81.00% <0.00%> (+0.08%) ⬆️
... and 6 more

@mergify mergify bot added the ci-passed label Jun 22, 2022
@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 21b52bf into milvus-io:master Jun 23, 2022
@XuanYang-cn XuanYang-cn deleted the fix-17676 branch April 26, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: --- FAIL: TestChannelManager_StateTransfer/ToWatch-WatchFail-ToRelease
3 participants