Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear segment cache when closing flowgraph #17671

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

XuanYang-cn
Copy link
Contributor

See also: #17537

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jun 21, 2022
@sre-ci-robot sre-ci-robot requested a review from cydrain June 21, 2022 07:35
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 21, 2022
@sre-ci-robot sre-ci-robot requested a review from sunby June 21, 2022 07:35
@mergify mergify bot added the dco-passed DCO check passed. label Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #17671 (358cdde) into master (e43f487) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17671      +/-   ##
==========================================
- Coverage   81.01%   80.98%   -0.03%     
==========================================
  Files         468      468              
  Lines       74384    74389       +5     
==========================================
- Hits        60263    60245      -18     
- Misses      11443    11463      +20     
- Partials     2678     2681       +3     
Impacted Files Coverage Δ
internal/datanode/data_sync_service.go 75.00% <100.00%> (+0.60%) ⬆️
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-1.70%) ⬇️
internal/datacoord/segment_manager.go 83.49% <0.00%> (-1.59%) ⬇️
internal/mq/msgstream/mq_msgstream.go 78.64% <0.00%> (-0.87%) ⬇️
internal/proxy/util.go 85.71% <0.00%> (-0.72%) ⬇️
internal/querycoord/query_coord.go 75.10% <0.00%> (-0.61%) ⬇️
internal/querycoord/task.go 77.38% <0.00%> (-0.22%) ⬇️
internal/rootcoord/root_coord.go 78.68% <0.00%> (-0.09%) ⬇️
internal/rootcoord/meta_table.go 81.35% <0.00%> (+0.08%) ⬆️
internal/querycoord/impl.go 91.46% <0.00%> (+0.09%) ⬆️

@mergify mergify bot added the ci-passed label Jun 21, 2022
@XuanYang-cn
Copy link
Contributor Author

#17432

@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-checks can trigger the job again.

See also: milvus-io#17537

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Jun 21, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1215843 into milvus-io:master Jun 22, 2022
@XuanYang-cn XuanYang-cn deleted the fix-segment-cache branch April 26, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants