-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make LoadCollection compatible #17669
Conversation
See also: milvus-io#17656 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
/assign @congqixia |
@XuanYang-cn E2e jenkins job failed, comment |
@XuanYang-cn ut workflow job failed, comment |
rerun ut |
@XuanYang-cn ut workflow job failed, comment |
rerun ut |
1 similar comment
rerun ut |
@@ -2576,6 +2576,11 @@ func (lct *loadCollectionTask) PreExecute(ctx context.Context) error { | |||
return err | |||
} | |||
|
|||
// To compat with LoadCollcetion before Milvus@2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #17669 +/- ##
==========================================
+ Coverage 81.01% 81.03% +0.01%
==========================================
Files 468 468
Lines 74402 74405 +3
==========================================
+ Hits 60276 60293 +17
+ Misses 11449 11436 -13
+ Partials 2677 2676 -1
|
See also: #17656
Signed-off-by: yangxuan xuan.yang@zilliz.com
/kind improvement