Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LoadCollection compatible #17669

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

XuanYang-cn
Copy link
Contributor

See also: #17656

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind improvement

See also: milvus-io#17656

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jun 21, 2022
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 21, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jun 21, 2022
@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

1 similar comment
@XuanYang-cn
Copy link
Contributor Author

rerun ut

@@ -2576,6 +2576,11 @@ func (lct *loadCollectionTask) PreExecute(ctx context.Context) error {
return err
}

// To compat with LoadCollcetion before Milvus@2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: typo

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #17669 (673a937) into master (0282f69) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17669      +/-   ##
==========================================
+ Coverage   81.01%   81.03%   +0.01%     
==========================================
  Files         468      468              
  Lines       74402    74405       +3     
==========================================
+ Hits        60276    60293      +17     
+ Misses      11449    11436      -13     
+ Partials     2677     2676       -1     
Impacted Files Coverage Δ
internal/proxy/task.go 81.10% <100.00%> (+0.02%) ⬆️
internal/indexcoord/meta_table.go 81.73% <0.00%> (-1.45%) ⬇️
internal/datacoord/segment_manager.go 84.12% <0.00%> (-0.96%) ⬇️
internal/querycoord/task_scheduler.go 77.85% <0.00%> (-0.83%) ⬇️
internal/querycoord/task.go 77.12% <0.00%> (-0.76%) ⬇️
internal/rootcoord/meta_table.go 81.27% <0.00%> (-0.09%) ⬇️
internal/rootcoord/root_coord.go 78.76% <0.00%> (+0.08%) ⬆️
internal/datanode/data_node.go 81.02% <0.00%> (+0.34%) ⬆️
internal/indexcoord/index_coord.go 78.33% <0.00%> (+0.38%) ⬆️
internal/proxy/impl.go 90.06% <0.00%> (+0.49%) ⬆️
... and 4 more

@mergify mergify bot added the ci-passed label Jun 21, 2022
@sre-ci-robot sre-ci-robot merged commit e43f487 into milvus-io:master Jun 21, 2022
@XuanYang-cn XuanYang-cn deleted the 17656 branch April 26, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants