Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel timers while adding new timer #17511

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

XuanYang-cn
Copy link
Contributor

See also: #17335

Signed-off-by: yangxuan xuan.yang@zilliz.com

@sre-ci-robot sre-ci-robot requested review from cydrain and sunby June 13, 2022 03:20
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 13, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jun 13, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-checks can trigger the job again.

See also: milvus-io#17335

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn changed the title Cannel timers while adding new timer Cancel timers while adding new timer Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #17511 (7ccf03f) into master (c77bc81) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17511      +/-   ##
==========================================
+ Coverage   81.01%   81.04%   +0.03%     
==========================================
  Files         464      464              
  Lines       73204    73233      +29     
==========================================
+ Hits        59306    59353      +47     
+ Misses      11278    11270       -8     
+ Partials     2620     2610      -10     
Impacted Files Coverage Δ
internal/datacoord/channel_checker.go 97.22% <100.00%> (+0.02%) ⬆️
internal/datacoord/channel_manager.go 70.91% <100.00%> (+0.05%) ⬆️
internal/indexcoord/meta_table.go 81.91% <0.00%> (-1.30%) ⬇️
internal/indexnode/indexnode_mock.go 86.69% <0.00%> (-1.15%) ⬇️
internal/querynode/impl.go 47.01% <0.00%> (-0.85%) ⬇️
internal/mq/msgstream/mq_msgstream.go 78.51% <0.00%> (-0.30%) ⬇️
internal/rootcoord/root_coord.go 79.15% <0.00%> (-0.10%) ⬇️
internal/querycoord/task.go 77.09% <0.00%> (+0.33%) ⬆️
internal/rootcoord/task.go 78.20% <0.00%> (+0.39%) ⬆️
internal/indexcoord/index_coord.go 77.65% <0.00%> (+0.39%) ⬆️
... and 8 more

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify mergify bot added the ci-passed label Jun 13, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e6225d9 into milvus-io:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants