Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataNode processes event out of order #17440

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

XuanYang-cn
Copy link
Contributor

The probability is low so very unlikly to reproduce

See also: #15966

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind bug

The probability is low so very unlikly to reproduce

See also: milvus-io#15966

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jun 8, 2022
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby June 8, 2022 07:31
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 8, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #17440 (622ae37) into master (6426e3d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17440      +/-   ##
==========================================
+ Coverage   81.07%   81.14%   +0.06%     
==========================================
  Files         466      466              
  Lines       73458    73459       +1     
==========================================
+ Hits        59556    59605      +49     
+ Misses      11283    11239      -44     
+ Partials     2619     2615       -4     
Impacted Files Coverage Δ
internal/datanode/data_node.go 81.13% <100.00%> (+0.02%) ⬆️
internal/rootcoord/root_coord.go 79.47% <0.00%> (+0.08%) ⬆️
internal/querycoord/task.go 77.26% <0.00%> (+0.33%) ⬆️
internal/proxy/impl.go 90.06% <0.00%> (+0.49%) ⬆️
internal/querycoord/cluster.go 79.84% <0.00%> (+0.58%) ⬆️
internal/indexcoord/index_coord.go 78.72% <0.00%> (+0.79%) ⬆️
internal/querycoord/querynode.go 72.03% <0.00%> (+1.27%) ⬆️
internal/distributed/querycoord/client/client.go 72.44% <0.00%> (+2.04%) ⬆️
internal/proxy/channels_time_ticker.go 80.59% <0.00%> (+2.23%) ⬆️
internal/mq/mqimpl/rocksmq/client/client_impl.go 80.50% <0.00%> (+2.54%) ⬆️

@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4f66bcb into milvus-io:master Jun 8, 2022
@XuanYang-cn XuanYang-cn deleted the fix-15966 branch June 8, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants