Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug log in removing assignment #17427

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

XuanYang-cn
Copy link
Contributor

Signed-off-by: yangxuan xuan.yang@zilliz.com
/kind improvement

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jun 8, 2022
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby June 8, 2022 02:05
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 8, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #17427 (a18a06e) into master (a9ec1f8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17427      +/-   ##
==========================================
+ Coverage   81.07%   81.09%   +0.01%     
==========================================
  Files         466      466              
  Lines       73360    73400      +40     
==========================================
+ Hits        59480    59527      +47     
+ Misses      11259    11249      -10     
- Partials     2621     2624       +3     
Impacted Files Coverage Δ
internal/datacoord/channel_manager.go 72.07% <100.00%> (+0.20%) ⬆️
internal/indexnode/indexnode_mock.go 84.79% <0.00%> (-3.05%) ⬇️
internal/proxy/channels_time_ticker.go 80.59% <0.00%> (-2.24%) ⬇️
internal/proxy/segment.go 87.87% <0.00%> (-1.52%) ⬇️
internal/proxy/util.go 85.71% <0.00%> (-0.72%) ⬇️
internal/datacoord/services.go 86.35% <0.00%> (-0.15%) ⬇️
internal/datanode/data_node.go 81.10% <0.00%> (+0.06%) ⬆️
internal/rootcoord/root_coord.go 79.47% <0.00%> (+0.31%) ⬆️
internal/rootcoord/task.go 77.57% <0.00%> (+0.38%) ⬆️
internal/rootcoord/meta_table.go 90.00% <0.00%> (+0.65%) ⬆️
... and 5 more

@mergify mergify bot added the ci-passed label Jun 8, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1dbfebf into milvus-io:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants