Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataNode panic while allocating IDs #17294

Merged
merged 1 commit into from
May 31, 2022

Conversation

XuanYang-cn
Copy link
Contributor

See also: #17270

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind bug

See also: milvus-io#17270

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label May 31, 2022
@mergify mergify bot added the dco-passed DCO check passed. label May 31, 2022
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby May 31, 2022 08:36
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label May 31, 2022
@XuanYang-cn XuanYang-cn changed the title Fix DataNode panics while allocating IDs Fix DataNode panic while allocating IDs May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #17294 (26813a1) into master (9579a64) will decrease coverage by 0.10%.
The diff coverage is 82.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17294      +/-   ##
==========================================
- Coverage   80.75%   80.65%   -0.11%     
==========================================
  Files         462      464       +2     
  Lines       72187    72725     +538     
==========================================
+ Hits        58298    58659     +361     
- Misses      11284    11446     +162     
- Partials     2605     2620      +15     
Impacted Files Coverage Δ
internal/querynode/task_query.go 0.00% <0.00%> (ø)
internal/querynode/task_search.go 0.00% <0.00%> (ø)
internal/querynode/segment_loader.go 69.24% <47.36%> (-0.43%) ⬇️
internal/querynode/validate.go 75.82% <50.00%> (ø)
internal/querynode/retrieve.go 42.50% <75.00%> (ø)
internal/querynode/task.go 82.60% <76.47%> (+1.00%) ⬆️
internal/querynode/meta_replica.go 83.73% <86.20%> (-1.45%) ⬇️
internal/querynode/flow_graph_insert_node.go 63.06% <86.95%> (-0.44%) ⬇️
internal/querynode/flow_graph_delete_node.go 74.54% <87.50%> (-2.73%) ⬇️
internal/querynode/partition.go 92.15% <90.00%> (-7.85%) ⬇️
... and 45 more

@mergify mergify bot added the ci-passed label May 31, 2022
@soothing-rain
Copy link
Contributor

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d920e5c into milvus-io:master May 31, 2022
@XuanYang-cn XuanYang-cn deleted the fix-17270-1 branch April 26, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants