Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DataNode release rather than delete when reassign #17293

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Make DataNode release rather than delete when reassign #17293

merged 1 commit into from
Jun 2, 2022

Conversation

XuanYang-cn
Copy link
Contributor

  1. Reassgin now will assign to the original Node if no other nodes
    avaliable
  2. Make AddNode balance async: ToRealse + Reassign

See also: #16114, #17270

Signed-off-by: yangxuan xuan.yang@zilliz.com

@sre-ci-robot sre-ci-robot requested review from cydrain and sunby May 31, 2022 07:51
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 31, 2022
@XuanYang-cn
Copy link
Contributor Author

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label May 31, 2022
@mergify mergify bot added the dco-passed DCO check passed. label May 31, 2022
@XuanYang-cn XuanYang-cn mentioned this pull request May 31, 2022
Closed
1 task
@mergify
Copy link
Contributor

mergify bot commented May 31, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 31, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-checks can trigger the job again.

@XuanYang-cn XuanYang-cn mentioned this pull request May 31, 2022
Closed
1 task
@codecov
Copy link

codecov bot commented May 31, 2022 •
edited
Loading

Codecov Report

Merging #17293 (4043359) into master (63a31cc) will decrease coverage by 0.00%.
The diff coverage is 84.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17293      +/-   ##
==========================================
- Coverage   80.66%   80.66%   -0.01%     
==========================================
  Files         464      464              
  Lines       72723    72730       +7     
==========================================
+ Hits        58663    58665       +2     
- Misses      11443    11445       +2     
- Partials     2617     2620       +3
Impacted Files Coverage Δ
internal/datacoord/channel_manager.go 71.80% <83.58%> (+3.64%) ⬆️
internal/datacoord/policy.go 86.37% <100.00%> (-0.41%) ⬇️
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-1.70%) ⬇️
internal/rootcoord/task.go 76.61% <0.00%> (-1.19%) ⬇️
internal/datacoord/segment_manager.go 82.03% <0.00%> (-1.02%) ⬇️
internal/querynode/query_node.go 83.82% <0.00%> (-0.74%) ⬇️
internal/proxy/impl.go 89.58% <0.00%> (-0.51%) ⬇️
internal/rootcoord/meta_table.go 82.08% <0.00%> (-0.49%) ⬇️
internal/indexcoord/meta_table.go 83.24% <0.00%> (-0.26%) ⬇️
internal/rootcoord/root_coord.go 79.02% <0.00%> (-0.23%) ⬇️
... and 6 more

@mergify mergify bot added the ci-passed label May 31, 2022
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jun 1, 2022
@mergify mergify bot removed the ci-passed label Jun 1, 2022
@XuanYang-cn
Make DataNode release rather than delete when reassign
4043359 
1. Reassgin now will assign to the original Node if no other nodes
   avaliable
2. Make AddNode balance async: ToRealse + Reassign

See also: milvus-io#16114, milvus-io#17270

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify mergify bot added the ci-passed label Jun 1, 2022
@XuanYang-cn XuanYang-cn requested a review from congqixia June 1, 2022 09:49
congqixia
congqixia reviewed Jun 2, 2022
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xiaofan-luan
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 42f643e into milvus-io:master Jun 2, 2022
@XuanYang-cn XuanYang-cn deleted the fix-16114-2 branch June 2, 2022 07:12
@XuanYang-cn XuanYang-cn mentioned this pull request Jun 8, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia left review comments

@cydrain cydrain Awaiting requested review from cydrain

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuanYang-cn @xiaofan-luan @sre-ci-robot @congqixia