Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear shard leaders cache when releasing #16942

Merged
merged 1 commit into from
May 17, 2022

Conversation

XuanYang-cn
Copy link
Contributor

See also: #16926

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label May 12, 2022
@mergify mergify bot added the dco-passed DCO check passed. label May 12, 2022
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 12, 2022
@XuanYang-cn
Copy link
Contributor Author

/cc @congqixia

@sre-ci-robot sre-ci-robot requested a review from congqixia May 12, 2022 07:18
@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-checks can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented May 13, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented May 13, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #16942 (36f72ff) into master (ffff291) will decrease coverage by 0.01%.
The diff coverage is 67.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16942      +/-   ##
==========================================
- Coverage   81.25%   81.24%   -0.02%     
==========================================
  Files         456      456              
  Lines       72733    72832      +99     
==========================================
+ Hits        59099    59170      +71     
- Misses      10913    10929      +16     
- Partials     2721     2733      +12     
Impacted Files Coverage Δ
internal/storage/local_chunk_manager.go 75.59% <50.00%> (-5.62%) ⬇️
internal/storage/minio_chunk_manager.go 68.87% <58.06%> (-6.89%) ⬇️
internal/kv/rocksdb/rocksdb_kv.go 83.97% <84.61%> (+1.36%) ⬆️
internal/core/src/segcore/SegmentSealedImpl.cpp 76.64% <100.00%> (ø)
internal/proxy/meta_cache.go 84.42% <100.00%> (+0.44%) ⬆️
internal/proxy/task.go 81.63% <100.00%> (+0.01%) ⬆️
internal/storage/vector_chunk_manager.go 73.93% <100.00%> (ø)
internal/util/funcutil/parallel.go 43.50% <0.00%> (-1.95%) ⬇️
internal/datacoord/segment_manager.go 81.35% <0.00%> (-1.70%) ⬇️
internal/querycoord/index_checker.go 74.25% <0.00%> (-1.20%) ⬇️
... and 17 more

@mergify mergify bot added the ci-passed label May 13, 2022
@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia please help review

@mergify
Copy link
Contributor

mergify bot commented May 16, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-checks can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented May 16, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented May 16, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

See also: milvus-io#16926

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn
Copy link
Contributor Author

/assign @congqixia

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a1480aa into milvus-io:master May 17, 2022
@XuanYang-cn XuanYang-cn deleted the 16926-1 branch May 17, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants