Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make proxy update cache with NotShardLeader status code #16940

Merged
merged 1 commit into from
May 13, 2022

Conversation

XuanYang-cn
Copy link
Contributor

See also: #16926

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 12, 2022
@sre-ci-robot sre-ci-robot requested review from bigsheeper and czs007 May 12, 2022 06:54
@mergify mergify bot added the dco-passed DCO check passed. label May 12, 2022
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 12, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn
Copy link
Contributor Author

rerun macos check

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

See also: milvus-io#16926

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #16940 (63385b7) into master (63385b7) will not change coverage.
The diff coverage is n/a.

❗ Current head 63385b7 differs from pull request most recent head d7e44b9. Consider uploading reports for the commit d7e44b9 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16940   +/-   ##
=======================================
  Coverage   81.18%   81.18%           
=======================================
  Files         457      457           
  Lines       72754    72754           
=======================================
  Hits        59066    59066           
  Misses      10963    10963           
  Partials     2725     2725           

@congqixia
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 43b36b4 into milvus-io:master May 13, 2022
@XuanYang-cn XuanYang-cn deleted the 16926-2 branch May 13, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants