Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ut for task_policies #16663

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

XuanYang-cn
Copy link
Contributor

See also: #16652

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind improvement

See also: milvus-io#16652

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Apr 26, 2022
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 26, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Apr 26, 2022
@XuanYang-cn
Copy link
Contributor Author

/cc @congqixia

@sre-ci-robot sre-ci-robot requested a review from congqixia April 26, 2022 06:59
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #16663 (2ab7c05) into master (bc5e9ec) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16663      +/-   ##
==========================================
+ Coverage   80.68%   80.75%   +0.07%     
==========================================
  Files         439      439              
  Lines       69426    69472      +46     
==========================================
+ Hits        56015    56104      +89     
+ Misses      10738    10695      -43     
  Partials     2673     2673              
Impacted Files Coverage Δ
internal/proxy/task_policies.go 66.00% <100.00%> (+31.90%) ⬆️
...nternal/querynode/flow_graph_filter_delete_node.go 80.51% <0.00%> (-5.20%) ⬇️
internal/querynode/flow_graph_delete_node.go 81.25% <0.00%> (-4.17%) ⬇️
internal/distributed/querynode/client/client.go 96.64% <0.00%> (-3.36%) ⬇️
internal/indexcoord/index_coord.go 76.55% <0.00%> (-2.03%) ⬇️
internal/datacoord/segment_manager.go 81.35% <0.00%> (-1.70%) ⬇️
internal/mq/msgstream/mq_msgstream.go 79.18% <0.00%> (-0.59%) ⬇️
internal/mq/mqimpl/rocksmq/server/rocksmq_impl.go 81.27% <0.00%> (-0.38%) ⬇️
internal/querycoord/task.go 76.96% <0.00%> (-0.33%) ⬇️
internal/querynode/query_shard.go 68.35% <0.00%> (-0.27%) ⬇️
... and 26 more

@mergify mergify bot added the ci-passed label Apr 26, 2022
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 35b7267 into milvus-io:master Apr 27, 2022
@XuanYang-cn XuanYang-cn deleted the proxy-ut branch May 31, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants