Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy unable to update cache #16646

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Apr 25, 2022

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind bug

#16652

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Apr 25, 2022
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 25, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Apr 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2022

@XuanYang-cn Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #16646 (5af126e) into master (bc5e9ec) will increase coverage by 0.02%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16646      +/-   ##
==========================================
+ Coverage   80.68%   80.71%   +0.02%     
==========================================
  Files         439      439              
  Lines       69426    69430       +4     
==========================================
+ Hits        56015    56038      +23     
+ Misses      10738    10721      -17     
+ Partials     2673     2671       -2     
Impacted Files Coverage Δ
internal/proxy/task_policies.go 31.25% <0.00%> (-2.85%) ⬇️
internal/proxy/task_query.go 47.00% <0.00%> (ø)
internal/proxy/task_search.go 46.71% <0.00%> (ø)
internal/distributed/querynode/client/client.go 96.64% <100.00%> (-3.36%) ⬇️
...nternal/querynode/flow_graph_filter_delete_node.go 80.51% <0.00%> (-5.20%) ⬇️
internal/querynode/flow_graph_delete_node.go 81.25% <0.00%> (-4.17%) ⬇️
internal/mq/msgstream/mq_msgstream.go 79.18% <0.00%> (-0.59%) ⬇️
internal/proxy/impl.go 82.67% <0.00%> (-0.47%) ⬇️
internal/rootcoord/meta_table.go 80.86% <0.00%> (+0.18%) ⬆️
... and 10 more

@XuanYang-cn
Copy link
Contributor Author

#16652

@XuanYang-cn
Copy link
Contributor Author

rerun macos check

@XuanYang-cn
Copy link
Contributor Author

rerun ut

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fbc7fe1 into milvus-io:master Apr 26, 2022
@XuanYang-cn XuanYang-cn deleted the fix-proxy-update-cache branch April 26, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants