Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReplicaInfo package name #16400

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

congqixia
Copy link
Contributor

Fix #16399
PR 16373 breaks the build after ReplicaInfo moved from querypb to milvuspb

/kind bug

Signed-off-by: Congqi Xia congqi.xia@zilliz.com

@sre-ci-robot sre-ci-robot added kind/bug Issues or changes related a bug approved labels Apr 6, 2022
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 6, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Apr 6, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2022

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

@XuanYang-cn
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #16400 (63f317d) into master (1e6f6bd) will decrease coverage by 0.01%.
The diff coverage is 82.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16400      +/-   ##
==========================================
- Coverage   81.47%   81.45%   -0.02%     
==========================================
  Files         425      426       +1     
  Lines       65259    65431     +172     
==========================================
+ Hits        53167    53298     +131     
- Misses       9618     9652      +34     
- Partials     2474     2481       +7     
Impacted Files Coverage Δ
internal/querynode/shard_cluster.go 100.00% <ø> (ø)
internal/querynode/shard_node_detector.go 82.55% <82.55%> (ø)
internal/proxy/channels_time_ticker.go 75.37% <0.00%> (-5.23%) ⬇️
internal/mq/mqimpl/rocksmq/client/client_impl.go 76.03% <0.00%> (-1.66%) ⬇️
internal/proxy/proxy.go 61.88% <0.00%> (-1.40%) ⬇️
internal/querynode/query_collection.go 80.66% <0.00%> (-0.42%) ⬇️
internal/rootcoord/task.go 78.62% <0.00%> (-0.39%) ⬇️
internal/mq/mqimpl/rocksmq/server/rocksmq_impl.go 81.27% <0.00%> (-0.38%) ⬇️
internal/rootcoord/root_coord.go 80.83% <0.00%> (-0.11%) ⬇️
internal/datacoord/server.go 73.64% <0.00%> (+0.77%) ⬆️
... and 3 more

@congqixia congqixia force-pushed the fix_replicainfo_pkg branch from 755fdb2 to 4acd859 Compare April 6, 2022 10:03
@sre-ci-robot sre-ci-robot removed the lgtm label Apr 6, 2022
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Fix milvus-io#16399
PR 16373 breaks the build after ReplicaInfo moved from querypb to milvuspb
Also fix  problem in Makefile
Limit action/setup-go version to ~1.17.1(>=1.17.1 <1.18.0)

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia force-pushed the fix_replicainfo_pkg branch from 4acd859 to 63f317d Compare April 6, 2022 11:02
@mergify mergify bot added the ci-passed label Apr 6, 2022
@XuanYang-cn
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 4cb7c28 into milvus-io:master Apr 6, 2022
@congqixia congqixia deleted the fix_replicainfo_pkg branch May 30, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: master build failed due to conflicts prs
3 participants