Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using specific port in ut #16398

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

XuanYang-cn
Copy link
Contributor

Signed-off-by: yangxuan xuan.yang@zilliz.com

/kind improvement

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Apr 6, 2022
@sre-ci-robot sre-ci-robot requested review from cydrain and czs007 April 6, 2022 06:28
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 6, 2022
@mergify mergify bot added dco-passed DCO check passed. ci-passed labels Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #16398 (d737ef0) into master (7161a77) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16398      +/-   ##
==========================================
+ Coverage   81.48%   81.53%   +0.04%     
==========================================
  Files         425      425              
  Lines       65174    65174              
==========================================
+ Hits        53107    53138      +31     
+ Misses       9598     9570      -28     
+ Partials     2469     2466       -3     
Impacted Files Coverage Δ
internal/datacoord/segment_manager.go 81.78% <0.00%> (-1.04%) ⬇️
internal/rootcoord/import_manager.go 87.60% <0.00%> (-0.81%) ⬇️
internal/querycoord/segment_allocator.go 73.28% <0.00%> (-0.77%) ⬇️
internal/rootcoord/root_coord.go 80.67% <0.00%> (-0.11%) ⬇️
internal/rootcoord/task.go 78.62% <0.00%> (+0.38%) ⬆️
internal/proxy/impl.go 85.75% <0.00%> (+0.50%) ⬆️
internal/datacoord/server.go 73.64% <0.00%> (+0.77%) ⬆️
internal/distributed/querycoord/client/client.go 71.92% <0.00%> (+1.97%) ⬆️
internal/mq/mqimpl/rocksmq/client/client_impl.go 80.16% <0.00%> (+2.47%) ⬆️
internal/indexnode/indexnode_mock.go 87.87% <0.00%> (+3.03%) ⬆️

@sunby
Copy link
Contributor

sunby commented Apr 6, 2022

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 909dd73 into milvus-io:master Apr 6, 2022
@XuanYang-cn XuanYang-cn deleted the fix-connect-manager-ut branch May 31, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants