Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl GetReplicas in Proxy #16390

Merged

Conversation

XuanYang-cn
Copy link
Contributor

See also: #16298

Signed-off-by: yangxuan xuan.yang@zilliz.com

@XuanYang-cn XuanYang-cn requested review from yah01 and sunby April 6, 2022 02:10
@sre-ci-robot sre-ci-robot added area/api area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels Apr 6, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Apr 6, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2022

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

See also: milvus-io#16298

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn force-pushed the change-get-replica-proto branch from d092185 to 7f81c29 Compare April 6, 2022 02:21
@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-checks can trigger the job again.

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #16390 (7f81c29) into master (543ec4a) will increase coverage by 0.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16390      +/-   ##
==========================================
+ Coverage   81.42%   81.45%   +0.02%     
==========================================
  Files         425      425              
  Lines       65176    65186      +10     
==========================================
+ Hits        53071    53095      +24     
+ Misses       9629     9619      -10     
+ Partials     2476     2472       -4     
Impacted Files Coverage Δ
internal/distributed/proxy/service.go 69.65% <0.00%> (-0.33%) ⬇️
internal/distributed/querycoord/service.go 69.09% <0.00%> (ø)
internal/proxy/impl.go 85.52% <0.00%> (+0.26%) ⬆️
internal/querycoord/cluster.go 79.04% <0.00%> (ø)
internal/querycoord/impl.go 87.22% <0.00%> (ø)
internal/querycoord/meta.go 76.31% <0.00%> (ø)
internal/querycoord/replica.go 13.95% <33.33%> (ø)
internal/distributed/querycoord/client/client.go 69.95% <100.00%> (-1.98%) ⬇️
internal/util/mock/querycoord_client.go 100.00% <100.00%> (ø)
internal/querycoord/channel_allocator.go 97.56% <0.00%> (-2.44%) ⬇️
... and 12 more

@yah01
Copy link
Member

yah01 commented Apr 6, 2022

/lgtm

@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2022

@XuanYang-cn E2e jenkins job failed, comment /run-checks can trigger the job again.

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7820000 into milvus-io:master Apr 6, 2022
@XuanYang-cn XuanYang-cn deleted the change-get-replica-proto branch May 31, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants