Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Improve compaction performance #37234

Closed
1 task done
tedxu opened this issue Oct 29, 2024 · 1 comment
Closed
1 task done

[Enhancement]: Improve compaction performance #37234

tedxu opened this issue Oct 29, 2024 · 1 comment
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@tedxu
Copy link
Contributor

tedxu commented Oct 29, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Compaction operations are essential for maintaining the overall stability and performance of the system. Although stability has been significantly improved through memory control, as seen in issues like #30682 and #32612, performance concerns may persist. For instance, typical L0 and mixed compaction processes can take anywhere from minutes to hours to complete.

To address this, I suggest implementing benchmarks and profiling to assess the current state. Based on these findings, we can develop targeted fixes to enhance the performance of compaction operations.

Why is this needed?

No response

Anything else?

No response
@tedxu tedxu added the kind/enhancement Issues or changes related to enhancement label Oct 29, 2024
@tedxu tedxu mentioned this issue Oct 29, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Oct 29, 2024
@tedxu
enhance: generally improve the performance of mix compactions (#37163)
262a994 
See #37234

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
tedxu added a commit to tedxu/milvus that referenced this issue Oct 29, 2024
@tedxu
enhance: generally improve the performance of mix compactions (milvus…
e1991c0 
…-io#37163)

See milvus-io#37234

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu tedxu mentioned this issue Oct 29, 2024
Merged
tedxu added a commit that referenced this issue Oct 29, 2024
@tedxu
enhance: generally improve the performance of mix compactions (#37163)
076efa1 
See #37234

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu tedxu mentioned this issue Oct 30, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Oct 31, 2024
@tedxu
enhance: generally improve the performance of mix compactions #37163 (#…
e585f6d 
…37268)

See #37234
pr: #37163

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Nov 1, 2024
@tedxu
enhance: load deltalogs on demand when doing compactions (#37310)
b792b19 
See #37234

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu tedxu mentioned this issue Nov 6, 2024
Merged
xiaofan-luan pushed a commit that referenced this issue Nov 8, 2024
@tedxu
enhance: avoid memory copy and serde in mix compaction (#37479)
bc9562f 
See: #37234

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu tedxu mentioned this issue Nov 15, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Dec 2, 2024
@tedxu
enhance: try compact small segments first if they may compose a full …
3a7a8c7 
…segment (#37709)

See #37234

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
tedxu added a commit to tedxu/milvus that referenced this issue Dec 4, 2024
@tedxu
enhance: try compact small segments first if they may compose a full …
06301e9 
…segment (milvus-io#37709)

See milvus-io#37234

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
tedxu added a commit to tedxu/milvus that referenced this issue Dec 4, 2024
@tedxu
enhance: try compact small segments first if they may compose a full …
ff3cd49 
…segment (milvus-io#37709)

See milvus-io#37234

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu tedxu mentioned this issue Dec 4, 2024
Closed
@stale Stale
Copy link

stale bot commented Dec 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Dec 4, 2024
@tedxu tedxu mentioned this issue Dec 10, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Dec 11, 2024
@tedxu
enhance: improve mix compaction performance by removing max segment l…
dc85d8e 
…imitations (#38344)

See #37234

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@stale stale bot closed this as completed Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tedxu