Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: milvus merge config with custom config #22556

Open
1 task done
locustbaby opened this issue Mar 3, 2023 · 7 comments
Open
1 task done

[Feature]: milvus merge config with custom config #22556

locustbaby opened this issue Mar 3, 2023 · 7 comments
Assignees
Labels
kind/feature Issues related to feature request from users

Comments

@locustbaby
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

#22516
There are some tools inside of milvus' pod help milvus merge user's config into milvus.yaml, such as /milvus/tools/run-helm.sh,/milvus/tools/merge, but as default, merge will write the milvus.yaml which belong to user root, when milvus run as a non-root user, merge will fail.

Describe the solution you'd like.

I don't think the merge is necessary, most open-source projects will merge the user's config automatically, such as kubectl, helm, nginx and so on.
Wish milvus can accept the user's yaml and merge automatically and better don't add more options for forward compatibility

Describe an alternate solution.

No response

Anything else? (Additional Context)

No response

@locustbaby locustbaby added the kind/feature Issues related to feature request from users label Mar 3, 2023
@locustbaby
Copy link
Contributor Author

@jiaoew1991

@jiaoew1991
Copy link
Contributor

support read user. yaml, default.yaml, milvus.yaml as this order.

@xiaofan-luan
Copy link
Collaborator

/assign @smellthemoon

@arunkumara8
Copy link

@locustbaby Is there a fix or workaround for this issue?

@xiaofan-luan
Copy link
Collaborator

I believe @smellthemoon is working on that.
Let's fix it on 2.3.x

@smellthemoon
Copy link
Contributor

smellthemoon commented Feb 26, 2024

working on it now.

@smellthemoon
Copy link
Contributor

smellthemoon commented Feb 26, 2024

init container will read user. yaml, default.yaml, milvus.yaml and then write milvus.yaml, which may cause permission denied(write need root permissions). now #22583 support to multi yaml files. But init container has not removed now, so container still need root permissions.
two solution.

  1. remove init container. Test locally, it can not merge multi yaml files in master and v2.3. Discussed with @locustbaby , seems it has some bugs when upgrade. I will support the feature and try to reproduce it.
  2. change the document permission level. Considering the security issues, I am not very inclined to this method。

All in all, I will choose the first method to solve this problem at this stage and will update if there is any progress.

sre-ci-robot pushed a commit that referenced this issue Mar 15, 2024
related with: #22556

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Issues related to feature request from users
Projects
None yet
Development

No branches or pull requests

5 participants