Skip to content

Commit

Permalink
Enhance querycoord log (#10523)
Browse files Browse the repository at this point in the history
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
  • Loading branch information
czs007 authored Oct 24, 2021
1 parent 7acb489 commit 40750f0
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,11 @@ build-cpp-with-unittest:
# Run the tests.
unittest: test-cpp test-go

test-proxy:
@echo "Running go unittests..."
go test -race -coverpkg=./... -coverprofile=profile.out -covermode=atomic -timeout 5m github.com/milvus-io/milvus/internal/proxy -v


test-go: build-cpp-with-unittest
@echo "Running go unittests..."
@(env bash $(PWD)/scripts/run_go_codecov.sh)
Expand Down
2 changes: 1 addition & 1 deletion internal/querycoord/task.go
Original file line number Diff line number Diff line change
Expand Up @@ -1356,7 +1356,7 @@ func (wqt *watchQueryChannelTask) execute(ctx context.Context) error {

err := wqt.cluster.addQueryChannel(wqt.ctx, wqt.NodeID, wqt.AddQueryChannelRequest)
if err != nil {
log.Warn("watchQueryChannelTask: watchQueryChannel occur error", zap.Int64("taskID", wqt.getTaskID()))
log.Warn("watchQueryChannelTask: watchQueryChannel occur error", zap.Int64("taskID", wqt.getTaskID()), zap.Error(err))
wqt.setResultInfo(err)
return err
}
Expand Down
2 changes: 1 addition & 1 deletion internal/querynode/collection_replica.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ func (colReplica *collectionReplica) getCollectionByID(collectionID UniqueID) (*
func (colReplica *collectionReplica) getCollectionByIDPrivate(collectionID UniqueID) (*Collection, error) {
collection, ok := colReplica.collections[collectionID]
if !ok {
return nil, errors.New("collection hasn't been loaded or has been released, collection id = %d" + strconv.FormatInt(collectionID, 10))
return nil, errors.New("collection hasn't been loaded or has been released, collection id =" + strconv.FormatInt(collectionID, 10))
}

return collection, nil
Expand Down

0 comments on commit 40750f0

Please sign in to comment.