Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support specifying field schema to be cluster key #794

Merged

Conversation

congqixia
Copy link
Contributor

See also milvus-io/milvus#32939

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot requested review from sunby and yah01 July 25, 2024 09:22
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/M Denotes a PR that changes 30-99 lines. labels Jul 25, 2024
@congqixia
Copy link
Contributor Author

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Jul 25, 2024
@mergify mergify bot added the ci-passed auto merge needed label label Jul 25, 2024
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jul 25, 2024
@sre-ci-robot sre-ci-robot merged commit d26d3d7 into milvus-io:master Jul 25, 2024
7 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Jul 26, 2024
sre-ci-robot pushed a commit to milvus-io/milvus that referenced this pull request Jul 26, 2024
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
…lvus-io#35027)

See also milvus-io#32939 milvus-io/milvus-sdk-go#794

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants