Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to collection error in examples #773

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

siddarth99
Copy link
Contributor

Added create index before executing LoadCollection in examples

@sre-ci-robot
Copy link

Welcome @siddarth99! It looks like this is your first PR to milvus-io/milvus-sdk-go 🎉

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 14, 2024
@siddarth99 siddarth99 changed the title #568 fixing: failed to load collection error Fixes #568 failed to load collection error Jun 14, 2024
@siddarth99 siddarth99 changed the title Fixes #568 failed to load collection error Closes #568 failed to load collection error Jun 14, 2024
@siddarth99
Copy link
Contributor Author

Closes #568

@siddarth99
Copy link
Contributor Author

/assign @congqixia

Signed-off-by: Sidharh Suvarna <siddarthsuvarna99@gmail.com>
Signed-off-by: Sidharth <sidharths@unicourt.com>
@siddarth99 siddarth99 changed the title Closes #568 failed to load collection error fix: failed to collection error in examples Jun 14, 2024
issue: milvus-io/milvus#32282

- Add UpdateResourceGroups and modify AddResourceGroup api.

- Add example for add resource group declarative api.

---------

Signed-off-by: chyezh <chyezh@outlook.com>
Signed-off-by: Sidharth <siddarthsuvarna99@gmail.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jun 17, 2024
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jun 17, 2024
@siddarth99
Copy link
Contributor Author

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Jun 17, 2024
@mergify mergify bot added the ci-passed auto merge needed label label Jun 18, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddarth99 Thanks for the patch!
/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jun 18, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, siddarth99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Jun 18, 2024
@sre-ci-robot sre-ci-robot merged commit 6404f1b into milvus-io:master Jun 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants