Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Merge Example app fixes into develop #3

Merged
fcancela merged 10 commits into from
Apr 12, 2022
Merged

Merge Example app fixes into develop #3

fcancela merged 10 commits into from
Apr 12, 2022

Conversation

@fcancela
Copy link
Contributor

@fcancela fcancela commented Apr 11, 2022 •
edited
Loading

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

New Feature Submissions:

  • Does your submission pass tests?
  • Have you lint your code locally prior to submission?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have verified the pub score with my changes

fcancela and others added 9 commits April 4, 2022 17:14
@fcancela
EA-review: Corrects example app issues.
89cbc05 
Publisher stops when app goes to background.
Settings state is stored and previous value of each setting is shown.
Mute/Unmute, Start/Stop states were corrected.
Display is now mirrored correctly.
resets publisher viewers once stream restarts.
changes example app bundle and appId
@fcancela
EA-review: change homepage of pubspec.yaml
97880a4
@fcancela
EA-review: remove unnecessary lines from pubspec.yaml
f2d2c21
@ftejeria
EA-review: change RTCRtp encoding params
39dc445
@ftejeria
EA-review: add av1 codec, disable simulcast for vp9 and av1
0da3ded
@ftejeria
EA-review: simulcast ui fix
95a56b6
@ftejeria
EA-review: change layer selection dynamically
76e7bc7
@goddino
Update README.md
8d3d780
@goddino
Merge pull request #2 from millicast/beta-test
c9819a0 
Update README.md
@fcancela fcancela requested a review from Jerricho93 April 11, 2022 21:06
@fcancela fcancela merged commit 1d270ad into develop Apr 12, 2022
@fcancela fcancela deleted the bugfix/EA-review branch April 14, 2022 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Jerricho93 Jerricho93 Jerricho93 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fcancela @Jerricho93 @ftejeria @goddino