Fix crash in milk-procCTRL when scanning removed processes#43
Fix crash in milk-procCTRL when scanning removed processes#43google-labs-jules[bot] wants to merge 1 commit intodevfrom
Conversation
Previously, `processinfo_shm_link` would call `exit(0)` if `open` or `mmap` failed. This caused the entire application to exit abruptly, leaving the terminal in a bad state (ncurses mode not restored). Changes: - Modified `processinfo_shm_link` in `src/CommandLineInterface/processinfo/processinfo_shm_link.c` to return `MAP_FAILED` on failure instead of calling `exit(0)`. - Updated `processinfo_shm_list_create` in `src/CommandLineInterface/processinfo/processinfo_shm_list_create.c` to handle the `MAP_FAILED` return value. - Removed `endwin()` call from `procCTRL_processinfo_scan.c` in the error handling path, as calling it from a background thread while the TUI is active is incorrect and unnecessary (the thread should just log the error and continue).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Fixed a crash in milk-procCTRL that occurred when a process was removed while the program was trying to read its data. The crash was caused by
processinfo_shm_linkcallingexit(0)on file open/map failure. Changed it to returnMAP_FAILEDand updated callers to handle the error gracefully. Also removed an incorrectendwin()call in the scan thread.PR created automatically by Jules for task 18024919748837170050 started by @oguyon