Draft
Conversation
3f2e082 to
7c400da
Compare
Member
|
Thanks Arnaud. Note that if the speed is maintained (RT MVM: critical; SVDs: non critical but convenient), we have no problems with dropping magma altogether, to get rid of some #ifdefs. |
43ad960 to
d3eaeb8
Compare
|
What is the status of removing the MAGMA dependency? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposition to remove magma dependency (but still optional)
When I writing this PR, it's not compiling on ArchLinux but it does on CeontOS 8 (could be a bug of the arch gcc).
What's changing ?
cudacomppsinvusesCUDACOMP_magma_compute_SVDpseudoInverse_cliwith USE_MAGMA=ON elseCUDACOMP_cusolver_compute_SVDpseudoInverse_clicudacomppsinv_magmaforCUDACOMP_magma_compute_SVDpseudoInverse_clicudacomppsinv_cusolverforCUDACOMP_cusolver_compute_SVDpseudoInverse_cliI also reworked
cudacomp_types.hto be remove MAGMA functions calls.