Attempting some stack safety strategies #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesfrain
commented
Jan 13, 2021
| @@ -860,7 +880,10 @@ foldM f b (a : as) = f b a >>= \b' -> foldM f b' as | |||
| -- | | |||
| -- | Running time: `O(n)` | |||
| mapReverse :: forall a b. (a -> b) -> List a -> List b | |||
| mapReverse f = go Nil | |||
| mapReverse f l = reverse $ map f l | |||
There was a problem hiding this comment.
Using this slower, but definitely stack safe alternative (not saying the other version is stack unsafe, but just trying to eliminate unknowns).
milesfrain
commented
Jan 13, 2021
| @@ -876,7 +899,10 @@ mapReverse f = go Nil | |||
| -- | | |||
| -- | Running time: `O(n)` | |||
| addIndexReverse :: forall a. List a -> List (Tuple Int a) | |||
| addIndexReverse = go 0 Nil | |||
| addIndexReverse = reverse <<< mapWithIndex Tuple | |||
There was a problem hiding this comment.
This should be stack safe too, right?
Closed
milesfrain
force-pushed
the
nub-ord-bench-stacksafe
branch
from
b7b3690 to
8bae586
Compare
milesfrain
commented
Jan 13, 2021
| benchLists "nubBySafe" $ nubBySafe compare -- safe | ||
| benchLists "addIndexReverse" addIndexReverse -- safe | ||
| benchLists "mapReverse" $ mapReverse $ add 1 -- safe | ||
| benchLists "sortBy" $ sortBy compare -- NOT SAFE!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nubBy's stack safety issue appears to be caused bynubByAdjacentReverse, but that function is stack safe on it's own.