Skip to content

Conversation

@RobTillaart
Copy link
Contributor

Changed under the hood implementation of AlarmHandler

  • removed defaultAlarmHandler() - was empty generated warnings.
  • added bool hasAlarmHandler() to show it has been set
  • updated constructors() - to "nullify" AlarmHandler
  • updated processAlarms() - no need to process them when there is no handler.

A better idea with breaking interface for the future might be to change processAlarms() to have the AlarmHandler() function as parameter.?

…); updated constructors() and processAlarms()
@RobTillaart RobTillaart changed the title issue 57 - removed defaultAlarmHandler(); added bool hasAlarmHandler(… issue #57 - removed defaultAlarmHandler(); Dec 22, 2017
@milesburton milesburton merged commit d3b74d6 into milesburton:master Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants