Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

589 validate objects coming via api #952

Merged
merged 10 commits into from
Aug 9, 2022
Merged

589 validate objects coming via api #952

merged 10 commits into from
Aug 9, 2022

Conversation

krllstdn
Copy link
Contributor

@krllstdn krllstdn commented Aug 1, 2022

Closes #589

@krllstdn krllstdn mentioned this pull request Aug 1, 2022
Closed
kristinagalik
kristinagalik suggested changes Aug 1, 2022
View reviewed changes
txmatching/configuration/config_parameters.py Outdated Show resolved Hide resolved
txmatching/configuration/configuration.py Outdated Show resolved Hide resolved
txmatching/data_transfer_objects/patients/txm_event_dto_in.py Outdated Show resolved Hide resolved
txmatching/data_transfer_objects/shared_dto.py Outdated Show resolved Hide resolved
txmatching/database/services/parsing_issue_service.py Outdated Show resolved Hide resolved
@krllstdn krllstdn requested a review from kubantjan August 4, 2022 12:41
kubantjan
kubantjan requested changes Aug 5, 2022
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall ok, small comments

txmatching/configuration/config_parameters.py Show resolved Hide resolved
txmatching/database/services/patient_service.py Show resolved Hide resolved
@krllstdn krllstdn force-pushed the 589_validate_objects_coming_via_api branch from 941458b to 52603d9 Compare August 9, 2022 08:24
kristinagalik
kristinagalik previously requested changes Aug 9, 2022
View reviewed changes
txmatching/data_transfer_objects/shared_dto.py Outdated Show resolved Hide resolved
txmatching/configuration/configuration.py Outdated Show resolved Hide resolved
txmatching/configuration/config_parameters.py Outdated Show resolved Hide resolved
txmatching/configuration/config_parameters.py Outdated Show resolved Hide resolved
tests/database/services/test_configuration.py Show resolved Hide resolved
kubantjan
kubantjan requested changes Aug 9, 2022
View reviewed changes
Copy link
Member

@kubantjan kubantjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny comment otherwise alright

tests/database/services/test_configuration.py Show resolved Hide resolved
@krllstdn krllstdn force-pushed the 589_validate_objects_coming_via_api branch from a622911 to 4fd3091 Compare August 9, 2022 15:10
@krllstdn krllstdn requested a review from kubantjan August 9, 2022 15:11
@kubantjan kubantjan merged commit 75f8a96 into master Aug 9, 2022
@kubantjan kubantjan deleted the 589_validate_objects_coming_via_api branch August 9, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubantjan kubantjan kubantjan approved these changes

@kristinagalik kristinagalik kristinagalik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate objects coming via API in BE via the integrated validator
3 participants
@krllstdn @kubantjan @kristinagalik